Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the issue where parts of the report were missing. #63

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yjmp14
Copy link

@yjmp14 yjmp14 commented Aug 9, 2024

Description

Incorrect use of the dedupe() function caused some content to be lost from the message retrieved from the webpage.
For example,
091100Z 0912/1018 12005KT 3500 BR RA SCT025 FEW030CB BKN080 BECMG 0915/0917 14005KT 3000 **BR** -RA **SCT025** BKN090 TEMPO 1000/1004 11008KT 1500 TSRA FEW015 **SCT025 FEW030CB** OVC090 **BECMG** 1005/1007 11010G20KT 2500 **BR -RA SCT025 BKN090 BECMG** 1015/1017 **14005KT 3000 BR -RA** FEW030 SCT090
After the dedupe(), the message comes to,
091100Z 0912/1018 12005KT 3500 BR RA SCT025 FEW030CB BKN080 BECMG 0915/0917 14005KT 3000 -RA BKN090 TEMPO 1000/1004 11008KT 1500 TSRA FEW015 OVC090 1005/1007 11010G20KT 2500 1015/1017 FEW030 SCT090
many parts are lost.

This PR fixed this issue.

Checklist

  • Tests covering the new functionality have been added
  • Documentation has been updated OR the change is too minor to be documented
  • Changes are listed in the CHANGELOG.md OR changes are insignificant

@devdupont
Copy link
Collaborator

Good catch. I think the original intention was to use dedupe(report.split(), only_neighbors=True) which would still yield the desired result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants