Fixes for adding Yii 2 to awesome list #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You should be notified by GitHub automatically. |
samdark
approved these changes
Oct 19, 2017
|
Oh yeah, you're right, I'm sorry 😃 |
|
It is a personal opinion, but I think that keeping Yii2 instead of Yii 2 helps with SEO and the marketing of Yii. As long as Yii1 (or Yii) is still around, people can differentiate between the two only by searching for the Yii2 term |
|
@mnglkhn I wasn't actually sure which approach to take, but I went with Yii 2 in the end. |
|
What? I'm OK with these changes since 19th October. You should see big green "Squash an merge" button so press it. |
|
@samdark |
|
Oh :) |
|
I am also don't see button in my PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes for the requirements mentioned in this Pull Request: PR.
Also, please notify me when you add the topics awesome and awesome-list to the repo (issue #22 ).