-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(cli): log SDK calls when using -vvv
#32308
base: main
Are you sure you want to change the base?
Conversation
(This work came out of the proxy issue research) The logging of what SDK calls were being performed was lost during the migration of SDKv2 -> SDKv3. Add it back. Also in this PR: - Set a timeout on `npm view`; if for network isolation reasons NPM can't connect to the server, it will make the CLI hang for a minute. - Work around an issue where the CLI entirely fails if it is run as a user that doesn't have a home directory.
Still a Draft because I'm not happy with how the messages are being formatted; there is too much detail in them as they include the entire API call payloads and responses (including somewhat-sensitive information). But creating a PR already anyway because I want to store this code somewhere safe. |
-vvv
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #32308 +/- ##
==========================================
- Coverage 77.46% 77.12% -0.35%
==========================================
Files 105 106 +1
Lines 7168 7209 +41
Branches 1314 1323 +9
==========================================
+ Hits 5553 5560 +7
- Misses 1433 1467 +34
Partials 182 182
Flags with carried forward coverage won't be shown. Click here to find out more.
|
The pull request linter fails with the following errors:
PRs must pass status checks before we can provide a meaningful review. If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
(This work came out of the proxy issue research)
The logging of what SDK calls were being performed was lost during the migration of SDKv2 -> SDKv3. Add it back.
Also in this PR:
npm view
; if for network isolation reasons NPM can't connect to the server, it will make the CLI hang for a minute.Closes #32306.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license