Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check regressions #3115

Merged
merged 7 commits into from
Oct 4, 2024
Merged

Check regressions #3115

merged 7 commits into from
Oct 4, 2024

Conversation

alextwoods
Copy link
Contributor

@alextwoods alextwoods commented Sep 24, 2024

This uses the new check-regressions task: https://github.com/aws/aws-sdk-ruby-benchmark-tools/blob/main/benchmark.rake#L115

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

  1. To make sure we include your contribution in the release notes, please make sure to add description entry for your changes in the "unreleased changes" section of the CHANGELOG.md file (at corresponding gem). For the description entry, please make sure it lives in one line and starts with Feature or Issue in the correct format.

  2. For generated code changes, please checkout below instructions first:
    https://github.com/aws/aws-sdk-ruby/blob/version-3/CONTRIBUTING.md

Thank you for your contribution!

@alextwoods alextwoods marked this pull request as draft September 24, 2024 21:01
Copy link

github-actions bot commented Sep 24, 2024

Detected 17 possible performance regressions:

  • aws-sdk-sns.require_time_ms - z-score regression: 78.66 -> 1564.57. Z-score: 5.74
  • aws-sdk-sns.client_init_ms - z-score regression: 1.34 -> 10.93. Z-score: 25.16
  • aws-sdk-sns.publish_small_ms - z-score regression: 2.99 -> 19.47. Z-score: 17.83
  • aws-sdk-sns.publish_large_ms - z-score regression: 4.85 -> 26.27. Z-score: 21.06
  • aws-sdk-cloudwatch.client_init_ms - z-score regression: 1.22 -> 9.13. Z-score: 12.31
  • aws-sdk-cloudwatch.put_metric_data_small_ms - z-score regression: 2.25 -> 10.0. Z-score: 7.79
  • aws-sdk-cloudwatch.put_metric_data_large_ms - z-score regression: 10.12 -> 22.13. Z-score: 11.08
  • aws-sdk-cloudwatchlogs.put_log_events_small_ms - z-score regression: 1.71 -> 7.47. Z-score: 5.77
  • aws-sdk-cloudwatchlogs.put_log_events_large_ms - z-score regression: 46.04 -> 96.07. Z-score: 15.37
  • aws-sdk-cloudwatchlogs.get_log_events_large_ms - z-score regression: 23.5 -> 42.27. Z-score: 12.69
  • aws-sdk-dynamodb.put_item_small_ms - z-score regression: 2.82 -> 6.2. Z-score: 5.48
  • aws-sdk-s3.client_init_ms - z-score regression: 1.76 -> 4.73. Z-score: 7.17
  • aws-sdk-s3.get_object_small_ms - z-score regression: 1.91 -> 6.53. Z-score: 13.23
  • aws-sdk-s3.put_object_small_ms - z-score regression: 2.7 -> 7.07. Z-score: 8.13
  • aws-sdk-s3.put_object_large_ms - z-score regression: 36.05 -> 39.21. Z-score: 9.84
  • aws-sdk-s3.put_object_multipart_large_ms - z-score regression: 49.64 -> 152.24. Z-score: 33.25
  • aws-sdk-s3.head_object_ms - z-score regression: 2.35 -> 10.0. Z-score: 29.73

@alextwoods alextwoods marked this pull request as ready for review October 4, 2024 17:31
@alextwoods alextwoods merged commit 353ba40 into version-3 Oct 4, 2024
30 checks passed
@alextwoods alextwoods deleted the check_regressions branch October 4, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants