Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: multi-treasury transfer contract RNSCommission #217

Closed
wants to merge 12 commits into from
Closed

feat: multi-treasury transfer contract RNSCommission #217

wants to merge 12 commits into from

Conversation

tringuyenskymavis
Copy link
Contributor

Description

This PR creates an RNSCommission contract for multi-treasury transfer.

@openzeppelin-code OpenZeppelin Code
Copy link

openzeppelin-code bot commented Jun 3, 2024 •
edited
Loading

feat: multi-treasury transfer contract RNSCommission

Generated at commit: b71cceb9a3861c3aa8f05b23390dcaae8bb8df1f

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total		 2
0
0
9
22
33
Dependencies Critical
High
Medium
Low
Note
Total		 0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

TuDo1403
TuDo1403 requested changes Jun 3, 2024
View reviewed changes
src/RNSCommission.sol Outdated Show resolved Hide resolved
src/RNSCommission.sol Outdated Show resolved Hide resolved
src/RNSCommission.sol Outdated Show resolved Hide resolved
src/RNSCommission.sol Outdated Show resolved Hide resolved
src/interfaces/INSCommission.sol Outdated Show resolved Hide resolved
src/RNSCommission.sol Outdated Show resolved Hide resolved
src/RNSCommission.sol Outdated Show resolved Hide resolved
TuDo1403
TuDo1403 requested changes Jun 3, 2024
View reviewed changes
src/RNSCommission.sol Outdated Show resolved Hide resolved
src/RNSCommission.sol Outdated Show resolved Hide resolved
TuDo1403
TuDo1403 reviewed Jun 3, 2024
View reviewed changes
src/RNSCommission.sol Outdated Show resolved Hide resolved
ducthotran2010
ducthotran2010 requested changes Jun 3, 2024
View reviewed changes
Copy link
Collaborator

@ducthotran2010 ducthotran2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider fixing the issues I mentioned in the last PR

src/RNSCommission.sol Outdated Show resolved Hide resolved
src/RNSCommission.sol Outdated Show resolved Hide resolved
src/RNSCommission.sol Outdated Show resolved Hide resolved
src/RNSCommission.sol Outdated Show resolved Hide resolved
src/interfaces/INSCommission.sol Outdated Show resolved Hide resolved
src/RNSCommission.sol Outdated Show resolved Hide resolved
src/RNSCommission.sol Outdated Show resolved Hide resolved
TuDo1403
TuDo1403 reviewed Jun 4, 2024
View reviewed changes
src/RNSCommission.sol Outdated Show resolved Hide resolved
TuDo1403
TuDo1403 reviewed Jun 4, 2024
View reviewed changes
src/RNSCommission.sol Outdated Show resolved Hide resolved
TuDo1403
TuDo1403 reviewed Jun 4, 2024
View reviewed changes
src/RNSCommission.sol Outdated Show resolved Hide resolved
nxqbao
nxqbao previously approved these changes Jun 5, 2024
View reviewed changes
ducthotran2010
ducthotran2010 previously approved these changes Jun 5, 2024
View reviewed changes
Copy link
Collaborator

@ducthotran2010 ducthotran2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor:

  • treasury name
  • commission <> treasury

@tringuyenskymavis tringuyenskymavis changed the title Implement feature/multi treasury transfer/add interface feat: multi-treasury transfer contract RNSCommission Jun 6, 2024
TuDo1403
TuDo1403 reviewed Jun 6, 2024
View reviewed changes
src/RNSCommission.sol Outdated Show resolved Hide resolved
TuDo1403
TuDo1403 reviewed Jun 6, 2024
View reviewed changes
src/RNSCommission.sol Outdated Show resolved Hide resolved
TuDo1403
TuDo1403 reviewed Jun 6, 2024
View reviewed changes
src/RNSCommission.sol Outdated Show resolved Hide resolved
TuDo1403
TuDo1403 requested changes Jun 6, 2024
View reviewed changes
src/interfaces/INSCommission.sol Outdated Show resolved Hide resolved
TuDo1403
TuDo1403 reviewed Jun 6, 2024
View reviewed changes
src/RNSCommission.sol Outdated Show resolved Hide resolved
TuDo1403
TuDo1403 reviewed Jun 6, 2024
View reviewed changes
src/RNSCommission.sol Outdated Show resolved Hide resolved
TuDo1403
TuDo1403 reviewed Jun 6, 2024
View reviewed changes
src/RNSCommission.sol Outdated Show resolved Hide resolved
TuDo1403
TuDo1403 reviewed Jun 6, 2024
View reviewed changes
src/RNSCommission.sol Outdated Show resolved Hide resolved
TuDo1403
TuDo1403 reviewed Jun 6, 2024
View reviewed changes
src/RNSCommission.sol Outdated Show resolved Hide resolved
TuDo1403
TuDo1403 previously approved these changes Jun 6, 2024
View reviewed changes
Copy link
Collaborator

@TuDo1403 TuDo1403 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please make sure the logic is propoperly tested.

@TuDo1403 TuDo1403 marked this pull request as ready for review June 6, 2024 09:32
@TuDo1403
Copy link
Collaborator

Closed in favor of #220

@TuDo1403 TuDo1403 closed this Jun 24, 2024
@TuDo1403 TuDo1403 deleted the implement-feature/multi-treasury-transfer/add-interface branch July 11, 2024 07:25
@tringuyenskymavis tringuyenskymavis restored the implement-feature/multi-treasury-transfer/add-interface branch November 4, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TuDo1403 TuDo1403 TuDo1403 approved these changes

@ducthotran2010 ducthotran2010 ducthotran2010 left review comments

@nxqbao nxqbao nxqbao left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tringuyenskymavis @TuDo1403 @nxqbao @ducthotran2010