Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

音声処理の修正および破壊的変更 #684

Merged
merged 12 commits into from
Aug 31, 2023

Conversation

yuto-trd
Copy link
Member

このプルリクエストで何をやったのか?

  • SceneGraphを実装したときに、音声処理を実装していなかったのでその実装
  • また、Rendererでの音声処理をComposerクラスに移動した
  • Delayエフェクトのプロパティの単位を修正
  • 音声の再生位置がずれるのを修正
  • SoundEffectのプロパティUIを実装

やらなかったこと

できるようになること

できなくなること

破壊的変更

  • IRenderer
  • RenderLayer
  • RenderScene
  • ElementNodeTreeModel
  • NodeGroup
  • ISourceHandler
  • SourceOperation
  • Element

廃止するApi

リンクされたIsuues

@yuto-trd yuto-trd added bug Something isn't working breaking-change area-rendering RenderScene(SceneGraph)に関係する area-audio labels Aug 31, 2023
@yuto-trd yuto-trd changed the base branch from main to develop August 31, 2023 10:29
@yuto-trd yuto-trd force-pushed the breaking-changes-of-rendering branch from 876dbc4 to 83ca6b2 Compare August 31, 2023 10:29
@yuto-trd yuto-trd marked this pull request as ready for review August 31, 2023 10:32
@yuto-trd yuto-trd merged commit bd25a88 into develop Aug 31, 2023
@yuto-trd yuto-trd deleted the breaking-changes-of-rendering branch August 31, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-audio area-rendering RenderScene(SceneGraph)に関係する breaking-change bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant