feat: add http and grpc API call logs #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bap2pecs
requested review from
parketh,
gitferry,
lesterli,
SebastianElvis,
maurolacy and
gusin13
parketh
reviewed
Nov 25, 2024
SebastianElvis
approved these changes
Nov 25, 2024
|
seems CI was failing before this PR. need to investigate
|
|
will fix test together after the FP e2e test is fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
while debugging the issue where the L2 finalized head stuck due to a potential reorg, I found that we don't have server logs in the FG grpc server. So I don't know when op-node calls it with what data
so let's add logs for all API calls, for both http and grpc servers
this is built on top of #42
Test Plan
both passed