Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: eotsd --output flag #166

Merged
merged 4 commits into from
Nov 27, 2024
Merged

fix: eotsd --output flag #166

merged 4 commits into from
Nov 27, 2024

Conversation

RafilxTenfen
Copy link
Contributor

@RafilxTenfen RafilxTenfen commented Nov 26, 2024 •
edited
Loading

  • Respects the output flag of text or json

Closes #156

@RafilxTenfen RafilxTenfen self-assigned this Nov 26, 2024
@RafilxTenfen RafilxTenfen changed the title fix: output respect the printing flag fix: eotsd: --output flag Nov 26, 2024
@RafilxTenfen RafilxTenfen changed the title fix: eotsd: --output flag fix: eotsd --output flag Nov 26, 2024
Lazar955
Lazar955 approved these changes Nov 27, 2024
View reviewed changes
Copy link
Member

@Lazar955 Lazar955 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

gitferry
gitferry approved these changes Nov 27, 2024
View reviewed changes
Copy link
Member

@gitferry gitferry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@gitferry
Copy link
Member

gitferry commented Nov 27, 2024 •
edited
Loading

I just tested on my end. Seems the json string is printed out in a single line:

❯ ./build/eotsd keys add "test-key-101" --keyring-backend=test --output=json
override the existing name test-key-101 [y/N]: y
{"name":"test-key-101","type":"local","address":"bbn1qxpp4xqy207jmltuwcyp32ehqh7wyegtmmnmtn","pubkey":"{\"@type\":\"/cosmos.crypto.secp256k1.PubKey\",\"key\":\"AiY55uryx9t21fZU0ivKdR5aXDPla+juUGKWLX6GZKP9\"}","mnemonic":"charge grape trigger together episode wife evolve mystery rate spy mixed typical teach genius network tortoise purpose assist slow clown nut segment embrace ship","pubkey_hex":"2639e6eaf2c7db76d5f654d22bca751e5a5c33e56be8ee5062962d7e8664a3fd"}

Maybe we can format it better?

@RafilxTenfen RafilxTenfen merged commit 0fca54e into main Nov 27, 2024
12 checks passed
@RafilxTenfen RafilxTenfen deleted the rafilx/fix-output-print branch November 27, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lazar955 Lazar955 Lazar955 approved these changes

@gitferry gitferry gitferry approved these changes

@filippos47 filippos47 Awaiting requested review from filippos47

Assignees

@RafilxTenfen RafilxTenfen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

eotsd: --output flag not enforced on keys add cmd
3 participants
@RafilxTenfen @gitferry @Lazar955