Add Lombard Finality Provider #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @fruit37, can you update the PR description to follow this PR template and also check the checkboxes? |
|
Hey @RafilxTenfen, thank you. I have updated the description.
|
|
@fruit37 should I reopen the PR? |
@RafilxTenfen, yes, please. Thank you very much. |
| @@ -0,0 +1,11 @@ | |||
| { | |||
| "description": { | |||
| "moniker": "Lombard Finance", | |||
There was a problem hiding this comment.
Can you make sure that the moniker does not contains white spaces
https://github.com/babylonlabs-io/networks/blob/main/bbn-1/finality-providers/README.md?plain=1#L228
After updating, you need to resign and update the Lombard.sig
fruit37
commented
Oct 1, 2024
filippos47
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Lombard Finality Provider
Checklist
guide
Caution
The loss of the (generated keys + mnemonic) makes the finality provider
useless and unable to provide finality, which would lead to no transition to
later phases of the Babylon network.