Issue #21: Fix actions for views bulk operations, add message when th… #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenlampton
force-pushed
the
21-flag-actions
branch
from
658c99c
to
d5bac82
Compare
… message when they can't act.
jenlampton
force-pushed
the
21-flag-actions
branch
from
d5bac82
to
9b53ae0
Compare
herbdool
requested changes
Apr 21, 2021
| /** | ||
| * Form for configuring the Flag node action. | ||
| */ | ||
| function flag_node_action_form($context = array()) { |
There was a problem hiding this comment.
I'm not sure if these get called. From what I recall, core version of Bulk Actions didn't include the ability to have forms for configuring actions.
There was a problem hiding this comment.
Interested in this -- I have the same issue with a few modules I was trying to port in my spare time (e.g. node convert, organic groups I think).
| */ | ||
|
|
||
| /** | ||
| * Implements Drupal action. Flags any entity. |
There was a problem hiding this comment.
Should be "Backdrop action".
| /** | ||
| * Form for configuring the Flag node action. | ||
| */ | ||
| function flag_node_action_form($context = array()) { |
There was a problem hiding this comment.
I'm not sure if these get called. From what I recall, core version of Bulk Actions didn't include the ability to have forms for configuring actions.
herbdool
reviewed
Apr 21, 2021
| @@ -507,10 +507,33 @@ function flag_help($path, $arg) { | |||
| } | |||
|
|
|||
| /** | |||
| * Implements hook_init(). | |||
| * Implements hook_action_info(). | |||
There was a problem hiding this comment.
Just noticed this is in flag.module. Shouldn't it be in flag_actions.module?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21