Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove errant blank lines introduced my ipd code pyright add_type_ign… #21

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

willsheffler
Copy link
Contributor

@willsheffler willsheffler commented Nov 15, 2024

…ore_comments

Summary by Sourcery

Enhancements:

  • Remove unnecessary blank lines from various Python files to improve code readability.

Copy link
Contributor

sourcery-ai bot commented Nov 15, 2024

Reviewer's Guide by Sourcery

This pull request removes unnecessary blank lines that were introduced by pyright's add_type_ignore_comments functionality. The changes are purely cosmetic and do not affect functionality.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Remove unnecessary blank lines throughout the codebase
  • Remove blank lines after type ignore comments
  • Remove redundant blank lines between related code blocks
  • Remove extra blank lines after function/class definitions
  • Remove duplicate blank lines between statements
ipd/tests/sym/xtal/test_spacegroup_symelems.py
ipd/sym/old/pymol_symgen.py
ipd/sym/old/pymol_xyzmath.py
ipd/tests/dev/test_bunch.py
ipd/sym/sym_manager.py
ipd/crud/frontend.py
ipd/homog/hgeom.py
ipd/dock/rigid/rigidbody.py
ipd/dev/state/bunch.py
ipd/dev/state/contextual_state.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@willsheffler willsheffler merged commit 5bcc2fa into main Nov 15, 2024
1 check passed
@willsheffler willsheffler deleted the typecheck2 branch November 15, 2024 23:13
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @willsheffler - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant