Connection url with special characters #355
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If user write some config with special characters, like password is admin$$test, Url.parse() will output wrong result which used in machinepack-mysql line 225. We need warn people to use encodeURIComponent() to encode the password. Global URL class added in node v10, I wrote it just let you know here need some warnings, because I don't see the issue page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If user write some config with special characters, like password is admin$$test, Url.parse() will output wrong result which used in machinepack-mysql line 225. We need warn people to use encodeURIComponent() to encode the password.
Global URL class added in node v10, I wrote it just let you know here need some warnings, because I don't see the issue page.