Introduce CI and basic checks #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josecm
requested review from
sandro2pinto,
DavidMCerdeira and
danielRep
as code owners
josecm
force-pushed
the
feat/ci
branch
2 times, most recently
from
57062f9
to
37db7e8
Compare
danielRep
previously approved these changes
Oct 12, 2023
There was a problem hiding this comment.
Nothing to add. Seems good to me. Just don't forget to correct the gitlint error.
Please review the commit phrasing: introduce ci subomodule to submodule
Signed-off-by: Jose Martins <[email protected]>
When including ci.mk in the Makefile it is needed to check if the target rules are rules that will trigger a build or not as most CI rules don't require a build. Otherwise many operations needded only for a build will be triggered even if we are only, for example, checking code formatting. Signed-off-by: Jose Martins <[email protected]>
Signed-off-by: Jose Martins <[email protected]>
Signed-off-by: Jose Martins <[email protected]>
Signed-off-by: Jose Martins <[email protected]>
Done.
Typo fixed. |
danielRep
previously approved these changes
Oct 12, 2023
Signed-off-by: Jose Martins <[email protected]>
Signed-off-by: Jose Martins <[email protected]>
|
Just realized the name of the riscv build job was incorrect. Force pushed the correction. |
danielRep
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the bao-ci infrastructure as a git submodule and instantiates and creates Github actions for basic checks such as:
It adds status stickers to the readme file that display the status of the build checks. You can check out how this looks here.