Add alert routing #149

adrain-cb · 2023-08-11T21:43:15Z

Fixes Issue

Fixes #140

Changes proposed

Screenshots (Optional)

Note to reviewers

…-config

epociask

Let's also ensure to add:

Unit tests for new/changed code
Updated E2E tests to ensure proper config ingestion to alerting flow
Updated documentation detailing how to use this feature
A template file that users can copy and quickly fill in

internal/client/alert_client/alert_client.go

internal/core/alert.go

internal/config/config.go

internal/client/alert_client/pagerduty_client.go

internal/client/alert_client/alert_client.go

internal/client/alert_client/pagerduty_client.go

epociask

Generally looks a lot better and is certainly shaping up. Think we'll be smooth sailing the review round after this!

alerts-template.yaml

e2e/e2e_test.go

internal/alert/client_map.go

internal/client/slack_client.go

internal/config/config.go

docs/alert-routing.md

e2e/e2e.go

internal/core/alert.go

epociask · 2023-08-22T10:14:22Z

Can we also update the alerting documentation to reflect this new abstraction within its architecture diagrams and descriptions?

alerts-template.yaml

e2e/e2e.go

internal/alert/client_map.go

internal/alert/client_map_test.go

internal/alert/manager.go

internal/alert/store_test.go

epociask

Just a few knits and this should be good to go. This looks really good, thank you!

e2e/e2e_test.go

internal/alert/test_data/alert-routing-test.yaml

epociask

LGTM

adrain-cb added 7 commits August 9, 2023 13:59

merge local changes

2c0ebba

Merge branch 'master' of github.com:base-org/pessimism into add-alert…

6e6f75f

…-config

rebase

eb5d4a1

Alert client implementation, load alert-routing cfg

093af79

Fix

e0903d0

ignore files

bf9693d

Initial working implementation of alert routing

83acbb2

epociask reviewed Aug 17, 2023

View reviewed changes

adrain-cb added 2 commits August 21, 2023 16:00

refactored implementation, added tests

6305678

Some cleanup

ce59c8a

adrain-cb requested a review from epociask August 21, 2023 23:11

adrain-cb added 3 commits August 21, 2023 16:39

Add docs

a30df6c

Add docs

406bd57

Refactor alert success status, add test for pd client

ac7c5ed

adrain-cb marked this pull request as ready for review August 22, 2023 00:25

fix linting issues, rename config var

212a370

adrain-cb changed the title ~~Add alert config~~ Add alert routing Aug 22, 2023

epociask reviewed Aug 22, 2023

View reviewed changes

adrain-cb added 5 commits August 22, 2023 17:59

Address pr comments, add additional e2e test

c980a04

Cleanup e2e tests

19ad3ed

Add getname to alertclient interface

7694f66

handle test server close error

68bcf37

return err on no cfg file found

286337c

adrain-cb requested a review from epociask August 23, 2023 18:35

adrain-cb added 4 commits August 23, 2023 11:40

Update cfg template

f106488

Add env var yaml parsing

a523120

Fix expected slack resp

93092aa

update alerts_generated to gauge

843d332

revert last commit

43526c2

epociask reviewed Aug 24, 2023

View reviewed changes

e2e/e2e_test.go Outdated Show resolved Hide resolved

e2e/e2e_test.go Show resolved Hide resolved

internal/alert/test_data/alert-routing-test.yaml Show resolved Hide resolved

address nits

8a72cc6

epociask approved these changes Aug 24, 2023

View reviewed changes

adrain-cb merged commit 63104d3 into master Aug 24, 2023
6 checks passed

adrain-cb deleted the add-alert-config branch August 24, 2023 21:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add alert routing #149

Add alert routing #149

adrain-cb commented Aug 11, 2023 •

edited

Loading

epociask left a comment

epociask left a comment

epociask commented Aug 22, 2023

epociask left a comment

epociask left a comment

Add alert routing #149

Add alert routing #149

Conversation

adrain-cb commented Aug 11, 2023 • edited Loading

Fixes Issue

Changes proposed

Screenshots (Optional)

Note to reviewers

epociask left a comment

Choose a reason for hiding this comment

epociask left a comment

Choose a reason for hiding this comment

epociask commented Aug 22, 2023

epociask left a comment

Choose a reason for hiding this comment

epociask left a comment

Choose a reason for hiding this comment

adrain-cb commented Aug 11, 2023 •

edited

Loading