Add go-tree-sitter 20240827094217-dd81d9e9be82 #3366
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (go-tree-sitter) have been updated in this PR. Please review the changes. |
fmeum
added
presubmit-auto-run
fmeum
reviewed
Dec 10, 2024
| Author: Douglas Thor <[email protected]> | ||
| Date: Thu Nov 21 04:19:47 2024 +0000 | ||
|
|
||
| Run gazelle |
There was a problem hiding this comment.
Could you add the exact go install / run commands, including Gazelle versions?
|
+1 for keeping it in BCR instead of Doug's own fork. That reduces the bus factor by a lot. |
|
There is one issue with the BCR option: It doesn't support the old WORKSPACE stuff. (Right?) |
github-merge-queue bot
pushed a commit
to bazelbuild/rules_python
that referenced
this pull request
Dec 14, 2024
… Parameter Syntax) by using dougthor42's fork of go-tree-sitter (#2496) Replaces #2413. Fixes #2396. This updates the `go-tree-sitter` dependency to use my fork that includes `BUILD.bazel` files. Specifically, the `BUILD.bazel` files in the fork include references to top-level code like `array.h` which the original Gazelle-generated files for `go-tree-sitter` were not able to handle. I also include the test cases that @maffoo created in #2413 and verified that they (a) fail before the fix and (b) pass after the fix. The fork is: https://github.com/dougthor42/go-tree-sitter The branch that includes all changes is: https://github.com/dougthor42/go-tree-sitter/tree/for-rules-python-gazelle-plugin A couple notes: + I have a PR open to get `go-tree-sitter` into BCR [here](bazelbuild/bazel-central-registry#3366). However: 1. I'm having trouble getting tests to pass and to get things running locally to validate it 2. Using BCR would not fix things for people who still use WORKSPACE (right?) + The fork is _mostly_ [autogenerated BUILD.bazel files from gazelle](smacker/go-tree-sitter@cfa9bdf) but also contains: + [manual updates so that build files reference the toplevel `array.h` and other files](smacker/go-tree-sitter@63f89cd) + [replace all `smacker` with `dougthor42` so that `go build` works](smacker/go-tree-sitter@8a73cbd) + various other more minor things. + I was unable to get `go mod edit -replace` to work, so I've just manually updated `go.mod` and whatnot everywhere. If someone with more go knowledge has a suggestion I'm happy to hear it. --------- Co-authored-by: Matthew Neeley <[email protected]> Co-authored-by: Ignas Anikevicius <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
go-tree-sitter@ 20240827094217-dd81d9e9be82.go-tree-sitteris a dep ofrules_python_gazelle_plugin. The goal of gettinggo-tree-sitterinto BCR is to allow us to bump the grammar parser so that PEP 695 (Type Parameter Syntax) is correctly parsed by Gazelle (see bazelbuild/rules_python#2396 and bazelbuild/rules_python#2413).Similar to
circl(#674), the core patch03_add_autogenerated_build_files.patchwas autogenerated by Gazelle. The others were manually tweaked to get builds to work.Addressing some potential questions:
go-tree-sitterdoes not appear to be open to the ideadougthor42namespace) and I'm hesitant to have a Bus Factor of 1. I'm willing to maintain it, though. In fact, the patches in PR were based off my branch here: https://github.com/dougthor42/go-tree-sitter/tree/bcrrules_python_gazelle_pluginto depend on the fork instead.Related Links:
gazelleto support patching (rejected)gazelle(rejected)