-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
type(feat): Allow parsing of wheel file paths in requirements.in #2345
base: main
Are you sure you want to change the base?
type(feat): Allow parsing of wheel file paths in requirements.in #2345
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Is there a better way to do this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I think this is as good as we can get here.
If you would like to also add the wiring for bzlmod
(e.g. wire pip.override
to the whl_library
whl_name
attribute), then I'd be happy to merge this approach. After all we are planning to release 1.0
at some point soon and bzlmod
is a first class citizen.
I fixed the indentation. I am not going to dedicate more time to this for a while due to other priorities. Existing code I have all uses WORKSPACE still. If there is someone else who would be willing to implement the bzlmod side of things they are most welcome. |
#1689 is the ticket that this PR would fix. |
I have a
.whl
file inside my bazel repo. I would like to add this torequirements.in
likeAdding
extra_data
topip_compile
and passing this through is sufficient.eg
An issue I came across is pip tools puts the absolute path to the wheel in
requirements.txt
which isn't great.So I change the path back to a relative one in
dependency_resolver.py
Currenty you need to add labels for install_deps.
Is there a better way to do this?