wasm_bindgen: allow target name with directory #2758
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking at the current logic for setting
--out-dir
and--out-name
, it seems that the intention is to infer those from the target name. However, if a prefix is specified for the name (pkg/custom
),out-dir
is set as expected (pkg
), but that directory prefix is also set inout-name
(pkg/custom
). causing the build command to fail when it appends the two and ends up withpkg/pkg/custom
).This approach sets
out-name
to be the last path segment only.