-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moved rust extension rules into a separate rules_rust_ext
workspace.
#3007
base: main
Are you sure you want to change the base?
Conversation
6820db7
to
dc90468
Compare
483ad5b
to
373d886
Compare
877dedc
to
08678f2
Compare
@illicitonion @krasimirgg @hlopko I would love your input on this change. It's a massive breaking change but I think a better path forward to help ensure the |
Thank you I think it looks very reasonable, but also I'm not working in an environment where rules_rust+bzlmod is exercised, so it's hard to flag potential non-trivial issues with this. I just asked a few folks to take a look at this and share their thoughts. |
Curious about the motivation to put them all into a single |
I started down that path and hit the 80 job cap for BazelCI. For each extension I would want to test them on Linux, Linux RBE, MacOS, and Windows, and to have each product be it's own workspace didn't seem possible. Though @meteorcloudy maybe there's a way to raise that cap? edit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to do this, equally happy to have a per-extension module if that's practical :) Thanks for doing the work!
This change moves the
bindgen
,proto
, andwasm_bindgen
sub-packages intoextensions
which is isolated into it's own workspace calledrules_rust_ext
. The intent is improve ease of maintenance of both core and extension Rust rules by ensuring changes to extensions have no impact on the core rules. Core rules should never depend on extensions.Load statements should be updated according to the following table:
@rules_rust//bindgen
@rules_rust_ext//bindgen
@rules_rust//proto/prost
@rules_rust_ext//prost
@rules_rust//proto/protobuf
@rules_rust_ext//protobuf
@rules_rust//wasm_bindgen
@rules_rust_ext//wasm_bindgen
closes #2882