Use a separate Jinja env per extension #1658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreasgerstmayr
added a commit
to andreasgerstmayr/fava-portfolio-returns
that referenced
this pull request
Aug 12, 2023
Workaround for beancount/fava#1658
Jinja Environments cache templates by name, therefore we cannot use the same environment across extensions. Signed-off-by: Andreas Gerstmayr <[email protected]>
yagebu
force-pushed
the
jinja-env-per-ext
branch
from
62d6ff1
to
006574d
Compare
yagebu
approved these changes
Aug 19, 2023
|
Thanks for the review & merging :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I updated my two Fava extensions to load the CSS via
(possible since #1643)
However, I noticed that whenever I load extension A first, extension B gets the wrong stylesheet, and vice-versa. Turns out Jinja's Environment caches templates by name (https://github.com/pallets/jinja/blob/86f28a9df0a97a3d3bfa3785b082651e2a8e994d/src/jinja2/environment.py#L958) and therefore the
style.cssfile of the extension which was loaded first gets in the cache.I've updated the code to use a (overlay-)Environment per extension, which resolves this issue.