-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add data race detector plugin #130
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @AlphaDaze,
Thank you for your contribution. It looks good, however there are few things I'd like to be addressed before merging it. Please see attached comments.
Also, a major point, please remove any commented out code or add explanation why it's commend out and how it can be used in the future. We don't need any dead code in the repo :).
Let me know if something is unclear.
Many thanks,
Igor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing the comments. I found two more small issues, but I'm happy otherwise. Please either remove the commented out code I highlighted or add TODO/explanation why it's commented out.
The other things is commit messages. Could you please clean it up? Ideally we would like to have two commits. The first commit for changes to the core and then the second one adding the plugin. Shouldn't be too difficult to achieve with git rebase -i
and some amending.
Once that's done I'm happy with the PR, but I'll ask @jkressel to have a look as well, and once he approves it we can merge it.
Sounds good! Thanks for taking a look at it. I have rebased and squashed the relevant commits together as requested. If there is any other changes (however small), please do let me know. |
Looks good to me (I'm a new intern). The markdown reads well |
Looks good to me! I'll ask @jkressel to have a look now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, I'm happy to merge.
This PR adds a data race detector plugin. This plugin detects possible data races within the underlying program along with information that can be utilised for debugging.
The README provides further context for the plugin and its usage.
Compile with
make datarace_ft
and run withmambo_datarace_ft
. The plugin includes two algorithms which can be compiled separately:fasttrack
anddjit
. Both are happens-before algorithms withfasttrack
being an improvement overdjit
with both memory and runtime.All comments and suggestions are welcome!
Sample output