-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plugins: add markunmatched #4749
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this has a lot of potential as a more generic plugin -- some random thoughts:
- Instead of only focusing on "weak" matches, the plugin could map recommendation levels to different commands.
- These commands don't have to be limited to notifications
- The prompt option to create a "marker file" could also be a configurable command!
xargs -I $ touch $/beets-unmatched
|
||
def touch_unmatched(self, session, task): | ||
for path in task.paths: | ||
Path(path.decode('utf-8') + "/beets-unmatched").touch() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I imagine you wanted this file to be easily visible from the terminal/file browser, but my first thought was that it should probably be hidden (i.e. .beets-unmatched
).
Could be useful to make the filename configurable too.
Hey and thanks for the review @ybnd! Your points have made me think for a while about the purpose of this plugin, and I think I've reached good conclusions. In any case, I'd like to hear about use cases for the ideas you've suggested, in particular:
Although I am interested in hearing ideas, I tend to not want to add to many moving parts to this plugin. In fact, I was thinking even further, that perhaps what's implemented here could become an addition to the Add another Then, a user will be able to run something like:
Which will open Eventually though, copying the What do you think @sampsyo? Perhaps I should open a new PR with at least that idea added to |
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
I'm sorry that I don't have the bandwidth to carefully review this, but on principle, I certainly have no objection to adding that "file export" option to the |
Closing this, as progress seems better at #4807 . |
Description
Add a plugin useful for bulk importers.
To Do
docs/
to describe it.)docs/changelog.rst
near the top of the document.)