Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to test Flatpak with PyGame #59

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

rmartin16
Copy link
Member

@rmartin16 rmartin16 commented Oct 24, 2023

Previously, the app verification job for Flatpak would only run for Toga; this allows it to run for PyGame as well.

Alternatively, to avoid this in the future, it may be better to remove this check against the "framework" altogether and instead require the repo running the job to exclude invalid frameworks.

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@rmartin16 rmartin16 force-pushed the test-pygame-flatpak branch from 88ed7d5 to 55705da Compare October 24, 2023 16:35
Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All makes sense - and I agree it might be better to make the default "run everywhere", and then make the individual users of the template filter the specific frameworks that are tested.

@freakboy3742 freakboy3742 merged commit 1d10330 into beeware:main Oct 24, 2023
61 checks passed
@rmartin16 rmartin16 deleted the test-pygame-flatpak branch October 24, 2023 23:52
@rmartin16
Copy link
Member Author

rmartin16 commented Oct 25, 2023

All makes sense - and I agree it might be better to make the default "run everywhere", and then make the individual users of the template filter the specific frameworks that are tested.

Just fyi....this actually may be a bit more involved than I initially thought.

Presently, the primary consideration for whether a build is attempted for a particular output format is the OS of the GitHub CI runner. And then only Toga is allowed for the mobile platforms and PySide2 is excluded for several.

So, I think app-build-verify.yml may require a new input to explicitly specify the output formats to test for the a framework....instead of the inferring it from the runner OS.

[edit]
Though, requiring of specific list of output formats everywhere means that when a new one is added.....any repo using app-build-verify.yml will need to be updated individually.......maybe the output formats can be grouped (e.g. desktop-formats and mobile-formats or something)....idk...more thought needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants