Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MicroPython compatibility #240

Merged
merged 2 commits into from
Dec 5, 2024
Merged

MicroPython compatibility #240

merged 2 commits into from
Dec 5, 2024

Conversation

mhsmith
Copy link
Member

@mhsmith mhsmith commented Dec 5, 2024

The current stable Travertino is already MicroPython-compatible (at least as far as importing), but the development version uses some unsupported *iterable syntax (error message here).

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

How hard would it be to add a CI pass to run the test suite on MicroPython? Otherwise it feels like this sort of bug will leak in again over time.

@freakboy3742 freakboy3742 merged commit d67a58f into beeware:main Dec 5, 2024
9 checks passed
@mhsmith
Copy link
Member Author

mhsmith commented Dec 5, 2024

The import compatibility check in beeware/toga#2976 will also cover Travertino. Actually running the test suite on MicroPython will require either pytest to be compatible with MicroPython, or upytest to be compatible with our test suite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants