Merge pull request #58 from belgattitude/feat/invalid-array-access

refactor(array-proxy): do not implement \ArrayAccess
belgattitude · Jul 10, 2020 · 2ae2d0b · 2ae2d0b
2 parents 38ccc59 + 017c12a
commit 2ae2d0b
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,16 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/)
 and this project adheres to [Semantic Versioning](http://semver.org/).
 
+## 2.8.1 (2020-07-10)
+
+### Changed
+
+- ArrayProxy, do not implement \ArrayAccess anymore, in [#58](https://github.com/belgattitude/soluble-japha/pull/58)
+
+### Dev
+
+- [Q&A] update phpstan and cs-fixer, in [#58](https://github.com/belgattitude/soluble-japha/pull/58)
+
 ## 2.8.0 (2020-04-10)
 
 ### Removed

diff --git a/composer.json b/composer.json
@@ -33,12 +33,12 @@
     },
     "require-dev" : {
         "phpunit/phpunit": "^7.5",
-        "friendsofphp/php-cs-fixer": "^2.15",
+        "friendsofphp/php-cs-fixer": "^2.16.4",
         "monolog/monolog": "^2.0",
-        "phpstan/phpstan": "^0.12.9",
+        "phpstan/phpstan": "^0.12.32",
         "phpstan/phpstan-strict-rules": "^0.12",
         "phpstan/phpstan-phpunit": "^0.12",
-        "belgattitude/pjbserver-tools": "^3.0",
+        "belgattitude/pjbserver-tools": "^3.1",
         "infection/infection": "^0.14"
     },
     "scripts": {

diff --git a/src/Soluble/Japha/Bridge/Driver/Pjb62/AbstractJava.php b/src/Soluble/Japha/Bridge/Driver/Pjb62/AbstractJava.php
@@ -209,6 +209,7 @@ public function offsetExists($idx, ...$args): bool
         // suggest, let's try for a java method called offsetExists
         // with all the provided parameters
         array_unshift($args, $idx); // Will add idx at the beginning of args params
+
         return $this->__call('offsetExists', $args);
     }
 

diff --git a/src/Soluble/Japha/Bridge/Driver/Pjb62/ArrayProxy.php b/src/Soluble/Japha/Bridge/Driver/Pjb62/ArrayProxy.php
@@ -39,7 +39,7 @@
 
 namespace Soluble\Japha\Bridge\Driver\Pjb62;
 
-class ArrayProxy extends IteratorProxy implements \ArrayAccess
+class ArrayProxy extends IteratorProxy
 {
     /**
      * @param string $idx