Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameter "topics" not working #5

Open
HLrwth opened this issue Dec 13, 2024 · 1 comment
Open

Parameter "topics" not working #5

HLrwth opened this issue Dec 13, 2024 · 1 comment

Comments

@HLrwth
Copy link

HLrwth commented Dec 13, 2024

Hi Bernd,

Thanks for sharing this amazing package. I noticed that for ROS iron, if I specified the topic list that I want to record with
parameter "topics", it still records all topics. I think the reason could be that in the recorder.cpp, the record_options is copied to the topic_filter_ when calling RecorderImpl constructor which is initialized with

rosbag2_transport::Recorder(
    std::make_shared<rosbag2_cpp::Writer>(), rosbag2_storage::StorageOptions(),
    rosbag2_transport::RecordOptions(), "recorder",
    rclcpp::NodeOptions(options).start_parameter_event_publisher(false))
@berndpfrommer
Copy link
Owner

I haven't noticed this problem yet. Looking forward to a PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants