This repository has been archived by the owner on Apr 11, 2024. It is now read-only.
Add support for more Samsung devices. #155
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for detecting Samsung Galaxy S8, S9, A-series, J-series
Detect BlackBerry Passport and manufacturer
Add more A5 and A7 model numbers
|
Add more A5 and A7 models |
bnjmnt4n
force-pushed
the
master
branch
4 times, most recently
from
8c56eeb
to
4453d52
Compare
|
@BdR76 Any chances your modifs are published somewhere? I'd like to keep using platformjs for a bit but I just got a specific ticket about those galaxy devices |
|
Doesn't look like the full change to platform.js is available because this pull request was reverted with another commit. I think it has to do with this other commit, which was a more robust away to detect Android devices. This old commit only added specific detection for up to the S9 models, because iirc that was the newest at that time. You could reconstruct it using this commit and the current version of the platform.js maybe? But then you'd probably also have to add the S20, S21, S22 etc. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for detecting Samsung Galaxy S8, S9, A-series, J-series