Drop obsolete IE detector as IE is not supported any more

bestpractical · Dec 30, 2024 · 91a4537 · 91a4537
1 parent eb7c52a
commit 91a4537
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 21 deletions.
diff --git a/lib/RT/Interface/Web.pm b/lib/RT/Interface/Web.pm
@@ -2223,11 +2223,6 @@ sub RequestENV {
     return $value;
 }
 
-sub ClientIsIE {
-    # IE 11.0 dropped "MSIE", so we can't use that alone
-    return RequestENV('HTTP_USER_AGENT') =~ m{MSIE|Trident/} ? 1 : 0;
-}
-
 =head2 ExpandShortenerCode $ARGS
 
 Expand shortener code and put expanded ones into C<$ARGS>.

diff --git a/lib/RT/Interface/Web/MenuBuilder.pm b/lib/RT/Interface/Web/MenuBuilder.pm
@@ -1815,12 +1815,10 @@ sub _BuildAdminPageMenu {
                 RT::Interface::Web::EscapeURI(\$Name_uri);
                 RT::Interface::Web::EscapeURI(\$Type_uri);
 
-                unless ( RT::Interface::Web->ClientIsIE ) {
-                    $page->child(
-                        basics     => title => loc('Modify'),
-                        path       => "/Admin/Lifecycles/Modify.html?Type=" . $Type_uri . ";Name=" . $Name_uri,
-                    );
-                }
+                $page->child(
+                    basics     => title => loc('Modify'),
+                    path       => "/Admin/Lifecycles/Modify.html?Type=" . $Type_uri . ";Name=" . $Name_uri,
+                );
                 $page->child( actions => title => loc('Actions'), path => "/Admin/Lifecycles/Actions.html?Type=" . $Type_uri . ";Name=" . $Name_uri );
                 $page->child( rights => title => loc('Rights'), path => "/Admin/Lifecycles/Rights.html?Type=" . $Type_uri . ";Name=" . $Name_uri );
                 $page->child( mappings => title => loc('Mappings'),  path => "/Admin/Lifecycles/Mappings.html?Type=" . $Type_uri . ";Name=" . $Name_uri );

diff --git a/share/html/Admin/Lifecycles/Advanced.html b/share/html/Admin/Lifecycles/Advanced.html
@@ -125,10 +125,6 @@
 
 $Config ||= JSON::to_json(RT->Config->Get('Lifecycles')->{$LifecycleObj->Name}, { canonical => 1, pretty => 1 });
 
-if ( $ARGS{RedirectedFromModify} && RT::Interface::Web->ClientIsIE() ) {
-    push @results, loc("The graphical lifecycle builder is not currently supported on IE 11. You can update the lifecycle configuration using the Advanced tab or access the lifecycle editor in a supported browser.");
-}
-
 if ( !defined $Maps && ( my $all_maps = RT->Config->Get('Lifecycles')->{__maps__} ) ) {
     for my $item ( grep {/^\Q$Name\E -> | -> \Q$Name\E$/} keys %$all_maps ) {
         $Maps->{$item} = $all_maps->{$item};

diff --git a/share/html/Admin/Lifecycles/Modify.html b/share/html/Admin/Lifecycles/Modify.html
@@ -70,12 +70,6 @@
 </form>
 <%INIT>
 
-if ( RT::Interface::Web->ClientIsIE() ) {
-    RT::Interface::Web::Redirect( RT->Config->Get('WebURL')
-            . "Admin/Lifecycles/Advanced.html?"
-            . $m->comp( '/Elements/QueryString', %ARGS, RedirectedFromModify => 1 ) );
-}
-
 my ($title, @results);
 my $LifecycleObj = RT::Lifecycle->new();
 $LifecycleObj->Load(Name => $Name, Type => $Type);