Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dd #8290

Closed
wants to merge 5 commits into from
Closed

dd #8290

wants to merge 5 commits into from

Conversation

togetherwithasteria
Copy link
Contributor

Objective

  • Describe the objective or issue this PR addresses.
  • If you're fixing a specific issue, say "Fixes #X".

Solution

  • Describe the solution used to achieve the objective above.

Changelog

This section is optional. If this was a trivial fix, or has no externally-visible impact, you can delete this section.

  • What changed as a result of this PR?
  • If applicable, organize changes under "Added", "Changed", or "Fixed" sub-headings
  • Stick to one or two sentences. If more detail is needed for a particular change, consider adding it to the "Solution" section
    • If you can't summarize the work, your change may be unreasonably large / unrelated. Consider splitting your PR to make it easier to review and merge!

Migration Guide

This section is optional. If there are no breaking changes, you can delete this section.

  • If this PR is a breaking change (relative to the last release of Bevy), describe how a user might need to migrate their code to support these changes
  • Simply adding new functionality is not a breaking change.
  • Fixing behavior that was definitely a bug, rather than a questionable design choice is not a breaking change.

togetherwithasteria and others added 5 commits March 24, 2023 18:08
@togetherwithasteria
Unnamed fields states support in derive(States)
9f593a6 
#8188
@togetherwithasteria
Merge branch 'bevyengine:main' into flara-patches
6854b2c
@togetherwithasteria
Merge branch 'bevyengine:main' into flara-patches
e0eefad
@togetherwithasteria
Substate (#4)
6e29053 
* Create SubstateLabel (and VariadicFn trait)
SubstateLabel is a schedule label that allows unnamed fields of State enums to be used as a schedule.
This depends on the VariadicFn trait which can be used on any type that implements Fn

Signed-off-by: Natalia Asteria <[email protected]>

* Rename SubstateLabel to SubstateInFn

Signed-off-by: Natalia Asteria <[email protected]>

* add SubstateInFn to bevy_ecs prelude

Signed-off-by: Natalia Asteria <[email protected]>

* Add test to SubstateInFn

Signed-off-by: Natalia Asteria <[email protected]>

* Fix F hitting trait bounds in SubstateInFn

Signed-off-by: Natalia Asteria <[email protected]>

* fix things

Signed-off-by: Natalia Asteria <[email protected]>

* okay

Signed-off-by: Natalia Asteria <[email protected]>

* test

Signed-off-by: Natalia Asteria <[email protected]>

* split substate code from state

Signed-off-by: Natalia Asteria <[email protected]>

* Rename SubstateScheduleLabel to SubstateLabel and create labels for it

Signed-off-by: Natalia Asteria <[email protected]>

* export substate in the prelude

Signed-off-by: Natalia Asteria <[email protected]>

* remove the <ParentState> type argument

Signed-off-by: Natalia Asteria <[email protected]>

* Change SubstateLabel into a trait and revert ScheduleLabel derive macro's macronized implementation

Signed-off-by: Natalia Asteria <[email protected]>

* Implement trait

Signed-off-by: Natalia Asteria <[email protected]>

* remove unnecessary things

Signed-off-by: Natalia Asteria <[email protected]>

---------

Signed-off-by: Natalia Asteria <[email protected]>
@togetherwithasteria
Merge branch 'bevyengine:main' into flara-patches
87d6709
@togetherwithasteria togetherwithasteria marked this pull request as ready for review April 2, 2023 00:23
@togetherwithasteria
Copy link
Contributor Author

OMG I'M SORRY I ACCIDENTALLY CLICKED IT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@togetherwithasteria