Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with phpredis driver #69

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

akalongman
Copy link

Fix issue with phpredis driver in the RedisCanBeAccessed checker

Related issue #68

@stefanzweifel
Copy link

As predis has been deprecated and phpredis should be used in the future, it would be awesome if this PR could be merged 👍

@akalongman
Copy link
Author

@stefanzweifel predis has been deprecated? Could you give some link about that?

@stefanzweifel
Copy link

Deprecated might be to harsh of a word 😅
The default Redis client in Laravel 6 has changed from predis to phpredis.

Predis has been abandoned by the package's original author and may be removed from Laravel in a future release.

Just upgraded an app to Laravel 6 and run into this issue, as we now use phpredis on production and had to disable this check.

@akalongman
Copy link
Author

@stefanzweifel huh, I did not know :) But its good news imho, because phpredis is a way better than predis. I did comparison on real production data: https://medium.com/@akalongman/phpredis-vs-predis-comparison-on-real-production-data-a819b48cbadb

@Jackpump
Copy link

Jackpump commented Aug 5, 2020

Could this PR be added to the project? I am interested in using this fix with my laravel project.

@WaveHack
Copy link

Just tested this and can confirm it's working (with PhpRedis from the PECL) 👍

Would also love to see this merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants