-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[client] cart페이지 반응형 구현 #30
Open
pki071120
wants to merge
7
commits into
develop
Choose a base branch
from
feature/applyResponsiveCartPage
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
gjaegyun
reviewed
Sep 25, 2024
Comment on lines
+26
to
+34
export const BottomBox = styled.div` | ||
width: 100%; | ||
height: 80%; | ||
display: flex; | ||
flex-direction: column; | ||
align-items: flex-start; | ||
gap: 1.25rem; | ||
margin-top: 3.5rem; | ||
`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
지금 state를 각각 pc, mobile layout에서 생성해주고 있는데 root에다가 선언하고 props로 내려주는 방식으로 변경해야 할거 같습니다 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요 💡
cart 반응형 구현
작업내용 ⌨️
반응형을 구현하여 폰을 사용할 때에도 디자인상 문제없이 사용할 수 있도록 제작하였습니다.
관련 issue 🤯
반응형 구현 작업을 처음 진행해보아서 많이 부족한 부분이 있을것 같습니다.