Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add product description to PDP #1790

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Conversation

jorgemoya
Copy link
Contributor

@jorgemoya jorgemoya commented Dec 19, 2024

What/Why?

  • Import latest changes from VIBES
  • Pass description and accordions

screencapture-localhost-3001-1-l-le-parfait-jar-2024-12-20-16_13_56

Copy link

changeset-bot bot commented Dec 19, 2024

⚠️ No Changeset found

Latest commit: 4bcc909

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 10:21pm
catalyst-soul ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 10:21pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
catalyst ⬜️ Ignored (Inspect) Dec 20, 2024 10:21pm
catalyst-au ⬜️ Ignored (Inspect) Visit Preview Dec 20, 2024 10:21pm
catalyst-uk ⬜️ Ignored (Inspect) Visit Preview Dec 20, 2024 10:21pm

@jorgemoya jorgemoya merged commit 79babd2 into soul/main Dec 20, 2024
12 of 14 checks passed
@jorgemoya jorgemoya deleted the soul-product-description branch December 20, 2024 22:35
Copy link
Contributor

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-n44w9upzg-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟢 Performance 96
🟢 Accessibility 92
🟢 Best practices 100
🟠 SEO 82

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟠 Performance 89
🟢 Accessibility 92
🟢 Best practices 100
🟠 SEO 85

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants