Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a health check #248

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add a health check #248

wants to merge 1 commit into from

Conversation

goose-ws
Copy link

Adds a health check to ensure the container and the outside internet are reachable

Adds a health check to ensure the container and the outside internet are reachable
@timrettop
Copy link

Any thoughts @binhex on accepting this PR?

@binhex
Copy link
Owner

binhex commented Nov 19, 2021

hi, so health checking is already performed inside of the container via scripts, including ping checks, dns lookup, etc, so if for instance your internet connection dropped then the required processes would get restarted in the correct order, including new port assignment.

Looking at the healthcheck instruction in the docker docs this looks to be a more basic command to simply stop the container should any of the test fail, which IMHO isn't really what most users are after, most people simply want the container to retry connection until the user either fixes their internet connection or stops the container.

The other issue around dns lookups, there are times during initialisation of the container where dns lookups will correctly fail, this is due to strict iptable rules preventing ip leakage, which could in turn trigger the healthcheck and thus a incorrect exit of the container.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants