Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create LSI is a POST call instead of PUT, it is defined for PUT but i… #101

Open
wants to merge 4 commits into
base: stable
Choose a base branch
from

Conversation

zslot
Copy link
Contributor

@zslot zslot commented Jun 29, 2016

…t reacts on POST. (gdb)

@msune
Copy link
Contributor

msune commented Aug 17, 2016

Hi Zsolt. Great that you take over this.

First could you split the two changes (DEB packaging and REST plugin in different branches). Since they are in the same branch, now I cannot easily (i.e. without modifying your history) merge one without the other.

Wrt to the original PR, the documentation was right as it should be a PUT rather than a POST (in REST philosophy). However, it is better than it was before, so I would merge that commit.

What I don't fully understand is what commit Controller connection details added to REST LSI creation call is trying to fix; could you please summarize?

Thanks
marc

@msune
Copy link
Contributor

msune commented Aug 17, 2016

Also, please note:

#93

@zslot
Copy link
Contributor Author

zslot commented Aug 18, 2016

Hi Marc, I have to thank.

Split done.

Regarding to REST API, there was no option in the stable release to create an LSI through REST and we needed for 5Gex. The creation of the LSI was extended to add the controller in one shot with the creation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants