Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dialyzer errors when using from_* functions #748

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

danturn
Copy link

@danturn danturn commented Oct 30, 2023

i was getting a dialyzer error when calling

Timex.Duration.from_hours() with a float

i believe that the code supports floats, but the typespec on one function is incorrect

this pr adds the | float to the from_microseconds function and adds some tests for calculating from_* with floats

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant