MB-64604: [BP] Fix interpreting scorch config: "fieldTFRCacheThreshold" #2118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
abhinavdangeti
commented
Dec 17, 2024
abhinavdangeti
commented
- Setting the default to 0 on account of the panics caught in the MB.
- Firstly, refactor FieldTFRCacheThreshold to fieldTFRCacheThreshold for some naming consistency here.
- This threshold can be used to toggle recycling of TermFieldReaders on/off.
- Couchbase users will have the ability to provide this setting within a JSON payload, which when interpreted into a map[string]interface{} will need to be interpreted as a float64.
- Should library users set it as an int within the index config - we'll honor that setting as well.
+ Setting the default to 0 on account of the panics caught in the MB.
+ Firstly, refactor FieldTFRCacheThreshold to fieldTFRCacheThreshold
for some naming consistency here.
+ This threshold can be used to toggle recycling of TermFieldReaders on/off.
+ Couchbase users will have the ability to provide this setting within a
JSON payload, which when interpreted into a map[string]interface{} will
need to be interpreted as a float64.
+ Should library users set it as an int within the index config - we'll
honor that setting as well.
abhinavdangeti
requested review from
Thejas-bhat,
metonymic-smokey,
CascadingRadium and
Likith101
CascadingRadium
previously approved these changes
Dec 17, 2024
abhinavdangeti
force-pushed
the
mb64604_71x
branch
from
9d77714 to
83855c1
Compare
Disable workflows on macos
abhinavdangeti
force-pushed
the
mb64604_71x
branch
from
214122b to
2009d67
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.