Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SDK build for macos #47

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Fix SDK build for macos #47

merged 1 commit into from
Nov 26, 2024

Conversation

johng
Copy link
Contributor

@johng johng commented Nov 26, 2024

Fixing compile error

Error compiling Cython file:

from .exceptions import BrokerTimeoutError
from .exceptions import Error

LOGGER = logging.getLogger(name)

BallUtil.initBallSingleton(_log_callback)
^

src/bloomberg/bmq/_ext.pyx:38:27: Cannot assign type 'void (const char *, int, const char *, int, const char ) except * nogil' to 'void ()(char *, int, char *, int, char *) noexcept'. Exception values are incompatible. Suggest adding 'noexcept' to the type of '_log_callback'.

Closes: #

Fixing compile error

Error compiling Cython file:
------------------------------------------------------------

from .exceptions import BrokerTimeoutError
from .exceptions import Error

LOGGER = logging.getLogger(__name__)

BallUtil.initBallSingleton(_log_callback)
                           ^
------------------------------------------------------------

src/bloomberg/bmq/_ext.pyx:38:27: Cannot assign type 'void (const char *, int, const char *, int, const char *) except * nogil' to 'void (*)(char *, int, char *, int, char *) noexcept'. Exception values are incompatible. Suggest adding 'noexcept' to the type of '_log_callback'.


Signed-off-by: John <[email protected]>
@johng johng requested a review from a team as a code owner November 26, 2024 16:05
@pniedzielski pniedzielski self-requested a review November 26, 2024 16:07
@pniedzielski pniedzielski self-assigned this Nov 26, 2024
@pniedzielski pniedzielski added bug Something isn't working skip news No news entry is required labels Nov 26, 2024
Copy link
Collaborator

@pniedzielski pniedzielski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

Thanks!

@pniedzielski pniedzielski merged commit c85c24f into bloomberg:main Nov 26, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working skip news No news entry is required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants