Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compiler warnings seen in gcc 14.2.1 #215

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

pablogsal
Copy link
Member

The latest version of gcc warns about a bunch of virtual destructors
needed on non final types and some braces for subobject initialization.

Issue number of the reported bug or feature request: #

Describe your changes
A clear and concise description of the changes you have made.

Testing performed
Describe the testing you have performed to ensure that the bug has been addressed, or that the new feature works as planned.

Additional context
Add any other context about your contribution here.

The latest version of gcc warns about a bunch of virtual destructors
needed on non final types and some braces for subobject initialization.

Signed-off-by: Pablo Galindo <[email protected]>
Copy link
Contributor

@godlygeek godlygeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pablogsal pablogsal merged commit 19b9759 into bloomberg:main Oct 30, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants