Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace BOOST_ASIO_INITFN_RESULT_TYPE with BOOST_ASIO_INITFN_AUTO_RESULT_TYPE #2728

Merged
merged 1 commit into from
Sep 5, 2023
Merged

Replace BOOST_ASIO_INITFN_RESULT_TYPE with BOOST_ASIO_INITFN_AUTO_RESULT_TYPE #2728

merged 1 commit into from
Sep 5, 2023

Conversation

ashtum
Copy link
Collaborator

@ashtum ashtum commented Aug 21, 2023

Fixes #2727.

klemens-morgenstern
klemens-morgenstern approved these changes Aug 21, 2023
View reviewed changes
Copy link
Collaborator

@klemens-morgenstern klemens-morgenstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Check that it works with C++11 though, maybe we need the PREFIX & _SUFFIX version.

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://2728.beastdocs.prtest.cppalliance.org/libs/beast/doc/html/index.html

@ashtum ashtum force-pushed the issue/2727 branch 2 times, most recently from ca27def to c1ff21c Compare August 22, 2023 06:09
@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://2728.beastdocs.prtest.cppalliance.org/libs/beast/doc/html/index.html

@codecov
Copy link

codecov bot commented Aug 22, 2023 •
edited
Loading

Codecov Report

Merging #2728 (9911a07) into develop (35d5332) will increase coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2728      +/-   ##
===========================================
+ Coverage    92.94%   92.97%   +0.02%     
===========================================
  Files          177      177              
  Lines        13658    13658              
===========================================
+ Hits         12694    12698       +4     
+ Misses         964      960       -4
Files Changed Coverage Δ
...ude/boost/beast/_experimental/test/impl/stream.hpp 98.68% <ø> (ø)
include/boost/beast/_experimental/test/stream.hpp 75.00% <ø> (ø)
include/boost/beast/core/basic_stream.hpp 80.39% <ø> (ø)
include/boost/beast/core/detect_ssl.hpp 92.42% <ø> (ø)
include/boost/beast/core/impl/basic_stream.hpp 86.11% <ø> (ø)
include/boost/beast/ssl/ssl_stream.hpp 0.00% <ø> (ø)

... and 1 file with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35d5332...9911a07. Read the comment docs.

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://2728.beastdocs.prtest.cppalliance.org/libs/beast/doc/html/index.html

@ashtum ashtum force-pushed the issue/2727 branch 2 times, most recently from f21278d to 36b4a22 Compare August 22, 2023 10:56
@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://2728.beastdocs.prtest.cppalliance.org/libs/beast/doc/html/index.html

1 similar comment
@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://2728.beastdocs.prtest.cppalliance.org/libs/beast/doc/html/index.html

@cppalliance-bot
Copy link

pullrequest
Timeline tracing charts: https://2728.beast.tracing.cppalliance.org/index.html

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://2728.beastdocs.prtest.cppalliance.org/libs/beast/doc/html/index.html

@ashtum
Replace BOOST_ASIO_INITFN_RESULT_TYPE with BOOST_ASIO_INITFN_AUTO_RES…
9911a07 
…ULT_TYPE

asio::deferred doesn't work with BOOST_ASIO_INITFN_RESULT_TYPE
Fixes boostorg#2727.
@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://2728.beastdocs.prtest.cppalliance.org/libs/beast/doc/html/index.html

@ashtum ashtum merged commit 45d4f7f into boostorg:develop Sep 5, 2023
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klemens-morgenstern klemens-morgenstern klemens-morgenstern approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

asio::deferred doesn't work with BOOST_ASIO_INITFN_RESULT_TYPE
3 participants
@ashtum @cppalliance-bot @klemens-morgenstern