Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use copy of x0 in scipy.optimize.newton to prevent side effect #134

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

maierbn
Copy link
Contributor

@maierbn maierbn commented Nov 13, 2024

This fixes the linked issue.

@maierbn maierbn linked an issue Nov 13, 2024 that may be closed by this pull request
@johannes-mueller
Copy link
Member

Is the new test actually sensitive for the change? I reverted the production code changes locally and the new test still passes.

@maierbn
Copy link
Contributor Author

maierbn commented Nov 14, 2024

I'm not sure, maybe it has to do with python 3.13?

@johannes-mueller
Copy link
Member

Or maybe Windows <> Linux?

So it does fail on your system without the changes?

@maierbn
Copy link
Contributor Author

maierbn commented Nov 14, 2024

No, the issue does not occur for me in the test. But when do basically the same in a different package that imports pylife (but in python 3.13), the issue occurs. Is it required to have a test for this PR to be mergable?

@johannes-mueller
Copy link
Member

Ah ok. There is actually a lot more issues with python 3.13 that I intent to address. Maybe check this workflow here

https://github.com/boschresearch/pylife/actions/runs/11832914483/job/32970554847

Maybe we should do that in one PR and at the same time add a python-3.13 test in the usual test suite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Side effect of notch_approximation_law.stress
2 participants