Add helper functions for ipcidr #116
Conversation
sources/api/schnauzer/Cargo.toml
Outdated
| settings-extension-oci-defaults.workspace = true | ||
| cidr = "0.2.3" |
There was a problem hiding this comment.
The CI should catch this when it runs, but you'll want to use workspace dependencies for this. Basically you'll want to:
- Add
cidr = 0.2to the[workspace.dependencies]list insources/Cargo.toml - Change this to
cidr.workspace = true.
make twoliter check should catch this too, if you want to try and replicate locally.
There was a problem hiding this comment.
Thanks for sharing this!
encountered in local run. Any clue what might be missed? I simply run the make twoliter check and testing looks good
[cargo-make] INFO - Running Task: check-migrations
grep: Release.toml: No such file or directory
[cargo-make] ERROR - Error while executing command, exit code: 2
[cargo-make] WARN - Build Failed.
Error: Command was unsuccessful, exit code 1
make: *** [twoliter] Error 1
There was a problem hiding this comment.
This actually seems to be a bug twoliter, sorry about that. I opened bottlerocket-os/twoliter#359 to track it.
We'll provide a fix for that, but in the meantime you'll have to separately run the individual check tasks: make twoliter unit-tests check-fmt check-lintsl.
There was a problem hiding this comment.
Ah, the individual check looks good to me
[cargo-make] INFO - Build Done in 52.05 seconds.
Description of changes:
Add new helper function for EKS to config the template
have to reopen new PR due to #102 uses develop branch and need to discard original commit to sync with latest.
Testing done:
Added unit test and
cargo testpassedTerms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.