Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for Issue #222: handle EOF and offset correctly on read #224

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix for Issue #222: handle EOF and offset correctly on read #224

wants to merge 3 commits into from

Commits on Feb 25, 2020

  1. Add some (failing) tests for Issue 222 (writing streams and feof())

    @IMSoP
    IMSoP committed Feb 25, 2020
    Configuration menu
    Copy the full SHA
    9be281d View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2020

  1. Fix for Issue bovigo#222: handle EOF and offset correctly on read 

    The EOF flag on native file streams is only set after reading *past*
the end of the buffer, never on open or seek.

I believe all the failing tests here are asserting behaviour that
doesn't match the native file handler.
    @IMSoP
    IMSoP committed Feb 26, 2020
    Configuration menu
    Copy the full SHA
    e4a5972 View commit details
    Browse the repository at this point in the history

  2. Issue bovigo#222: Fix tests which incorrectly modelled EOF & offset 

    Testing with normal files show that fread() does not progress the
pointer beyond the end of the file, and a read *beyond* the file size is
required before feof() returns true.
    @IMSoP
    IMSoP committed Feb 26, 2020
    Configuration menu
    Copy the full SHA
    28c71a7 View commit details
    Browse the repository at this point in the history