fix: stop using SharedLinkAPIConnection in getSharedItem()
#1234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build #3626Details
💛 - Coveralls |
antusus
reviewed
Feb 23, 2024
doc/shared-items.md
Outdated
| @@ -31,6 +31,7 @@ BoxItem.Info itemInfo = BoxItem.getSharedItem(api, sharedLink, password); | |||
| If you already know the type and ID of the item you want to access, you can | |||
| manually construct a [`SharedLinkAPIConnection`][shared-link-api] and make | |||
| API calls on the item directly. | |||
| Note: `SharedLinkAPIConnection` is now deprecated. Please use `BoxItem.getSharedItem()` method instead. | |||
|
|
|||
| ```java | |||
| String sharedLink = "https://app.box.com/s/abcdefghijklmnopqrstuvwxyz123456"; | |||
There was a problem hiding this comment.
If we mark it as deprecated why not provide example with new usage? And show it in the documentation instead of deprecated one.
There was a problem hiding this comment.
It's a few lines above
There was a problem hiding this comment.
do you think we should duplicate it here ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.