Merge pull request #196 from boxuk/fix/editor-tools/post-type-registr…

…ation [FIX] Ensure taxonomies are registered if no custom post-types are.
boxuk · Oct 30, 2024 · 6b0c127 · 6b0c127
2 parents f6c64d4 + e1afc2f
commit 6b0c127
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 2 deletions.
diff --git a/packages/editor-tools/schema/post-type.schema.json b/packages/editor-tools/schema/post-type.schema.json
@@ -461,6 +461,15 @@
 				"^[a-zA-Z0-9_]+$": {
 					"type": "object",
 					"properties": {
+						"post_types": { 
+							"type": "array",
+							"description": "An array of post type identifiers that will be registered for the taxonomy. Post types can be registered later with register_post_type() or register_post_type_for_object_type().",
+							"items": {
+								"type": "string",
+								"pattern": "^[a-zA-Z0-9_]+$",
+								"description": "Post type identifier"
+							}
+						},
 						"labels": {
 							"type": "object",
 							"description": "An array of labels for this taxonomy. If not set, taxonomy labels are inherited from post type labels. See [get_taxonomy_labels()](https://developer.wordpress.org/reference/functions/get_taxonomy_labels/) for a full list of supported labels.",

diff --git a/packages/editor-tools/src/PostTypes.php b/packages/editor-tools/src/PostTypes.php
@@ -42,7 +42,7 @@ public function register_post_types(): void {
 		}
 
 		foreach ( $data['taxonomies'] ?? array() as $name => $args ) {
-			register_taxonomy( $name, array(), $args );
+			register_taxonomy( $name, $args['post_types'] ?? 'post', $args );
 		}
 
 		foreach ( $data['post_types'] ?? array() as $name => $args ) {

diff --git a/packages/editor-tools/tests/TestPostTypes.php b/packages/editor-tools/tests/TestPostTypes.php
@@ -73,7 +73,7 @@ public function testRegisterPostTypes(): void {
 			->once()
 			->with( 
 				'example_category', 
-				array(), 
+				'post', 
 				array(
 					'labels'  => array(
 						'name'          => 'TestName',