Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove measurement code #135

Merged
merged 2 commits into from
Oct 27, 2023
Merged

Remove measurement code #135

merged 2 commits into from
Oct 27, 2023

Conversation

adamltyson
Copy link
Member

@adamltyson adamltyson commented Oct 26, 2023 •
edited
Loading

Closes #94

EDIT: Also closes #112

alessandrofelder
alessandrofelder approved these changes Oct 27, 2023
View reviewed changes
Copy link
Member

@alessandrofelder alessandrofelder left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 (test failures presumably related to #130 ...)

@alessandrofelder alessandrofelder merged commit 0150ee4 into main Oct 27, 2023
8 of 10 checks passed
@alessandrofelder alessandrofelder deleted the remove-measurement branch October 27, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alessandrofelder alessandrofelder alessandrofelder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename widget Move measurement code out of the package.
2 participants
@adamltyson @alessandrofelder