run CI on both types of Mac #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alessandrofelder
force-pushed
the
adapt-CI-mac
branch
from
4822b34 to
c8efef2
Compare
needed because different Mac architectures give slightly different numerical values.
alessandrofelder
force-pushed
the
adapt-CI-mac
branch
from
f4ff188 to
8b8d6e1
Compare
for more information, see https://pre-commit.ci
adamltyson
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is this PR
Why is this PR needed?
We'd like to run CI on both Intel and Silicon Macs.
What does this PR do?
This PR modifies the workflow file so that test and installation runs smoothly on both Mac architectures.
This required relaxing some tests' numerical verifications (presumably due to differences in the numerics of each piece of hardware).
References
Partial solution to brainglobe/BrainGlobe#63
How has this PR been tested?
CI runs observed.
Is this a breaking change?
No
Does this PR require an update to the documentation?
No
Checklist: