-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check benchmarks on CI #96
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfmig
force-pushed
the
smg/move-benchmark-testing-to-ci
branch
from
April 23, 2024 10:51
1c3dacc
to
10ce5ab
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #96 +/- ##
==========================================
+ Coverage 84.45% 85.69% +1.24%
==========================================
Files 17 16 -1
Lines 862 839 -23
==========================================
- Hits 728 719 -9
+ Misses 134 120 -14 ☔ View full report in Codecov by Sentry. |
This was referenced Apr 23, 2024
sfmig
force-pushed
the
smg/move-benchmark-testing-to-ci
branch
from
April 25, 2024 10:47
edd00b6
to
28ffd78
Compare
sfmig
force-pushed
the
smg/move-benchmark-testing-to-ci
branch
from
April 30, 2024 14:44
28ffd78
to
e097500
Compare
alessandrofelder
approved these changes
May 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows from #94
Description
What is this PR
Why is this PR needed?
To test the benchmarks.
What does this PR do?
We test the benchmarks on CI rather than with tests.
References from other Python packages using
asv
to benchmark:Currently we are running a very basic check. We can look into further extending this with maybe something closer to the napari or numpy approaches (see below).
References
This PR follows from #94 and relates to issue #9. It should be rebased to main after #94 is squash-and-merged.
How has this PR been tested?
Please explain how any new code has been tested, and how you have ensured that no existing functionality has changed.
Is this a breaking change?
If this PR breaks any existing functionality, please explain how and why.
Does this PR require an update to the documentation?
If any features have changed, or have been added. Please explain how the documentation has been updated (and link to the associated PR). See here for details.
Checklist: