Remove duplicate notfound-context dict from conf.py #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `notfound-context` dict seems to be defined twice in `conf.py`, and the 2nd definition seems to override the first one. I see no reason for keeping the first definition around.
adamltyson
approved these changes
Dec 2, 2024
rlokkie
added a commit
to rlokkie/brainglobe.github.io
that referenced
this pull request
Dec 4, 2024
commit 963a757 Author: Niko Sirmpilatze <[email protected]> Date: Mon Dec 2 10:27:41 2024 +0000 Remove duplicate notfound-context (brainglobe#267) The `notfound-context` dict seems to be defined twice in `conf.py`, and the 2nd definition seems to override the first one. I see no reason for keeping the first definition around. commit 7062240 Author: Adam Tyson <[email protected]> Date: Mon Nov 25 11:36:32 2024 +0000 Use bluesky icon (brainglobe#266) * Use bluesky icon * Update conf.py commit eac3fe3 Author: Adam Tyson <[email protected]> Date: Fri Nov 22 16:01:36 2024 +0000 Use custom domain for bluesky (brainglobe#265)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
notfound-contextdict seems to be defined twice inconf.py, and the 2nd definition seems to override the first one. I see no reason for keeping the first definition around.