-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement manager view and dialog #124
Conversation
and delegate tooltips to views
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #124 +/- ##
==========================================
+ Coverage 97.72% 98.06% +0.34%
==========================================
Files 9 11 +2
Lines 396 466 +70
==========================================
+ Hits 387 457 +70
Misses 9 9 ☔ View full report in Codecov by Sentry. |
+ tweak to avoid hard-coded column index
found a tiny bug in the process!
so it's picked up by coverage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍! I have a few small comments but nothing that needs to be urgently addressed.
The tooltips feel a bit sluggish, especially when moving the mouse within the same row. Is there any way to add a small delay before the tooltip is rendered?
Co-authored-by: Igor Tatarnikov <[email protected]>
Description
What is this PR
Why is this PR needed?
We'd like to have a separate table view that allows updating and downloading of atlases via the BrainGlobe atlas API
What does this PR do?
This PR
Some refactoring was needed so
References
Another step towards closing #21
How has this PR been tested?
New tests added to cover
Is this a breaking change?
Yes,
AtlasTableModel
constructor now takes an argumentview_type
, which specifies the class whoseget_tooltip_text
function it should call.Does this PR require an update to the documentation?
If any features have changed, or have been added. Please explain how the documentation has been updated (and link to the associated PR). See here for details.
Checklist: