Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explicitly depend on meshio #136

Merged
merged 1 commit into from
Feb 28, 2024
Merged

explicitly depend on meshio #136

merged 1 commit into from
Feb 28, 2024

Conversation

alessandrofelder
Copy link
Member

@alessandrofelder alessandrofelder commented Feb 28, 2024

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?
We use meshio but we don't explicitly depend on it.

What does this PR do?
Add meshio to the dependencies (also order dependencies alphabetically).

Checklist:

  • [n/a] The code has been tested locally
  • [n/a] Tests have been added to cover all new functionality (unit & integration)
  • [n/a] The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

@alessandrofelder alessandrofelder marked this pull request as ready for review February 28, 2024 11:07
@alessandrofelder alessandrofelder requested a review from a team February 28, 2024 11:07
Copy link
Contributor

@willGraham01 willGraham01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will make brainglobe/brainglobe-meta#40 (comment) a bit harder since we'll need meshio on conda-forge eventually, but better it works via pip in the first place.

@willGraham01 willGraham01 merged commit d93447b into main Feb 28, 2024
10 checks passed
@willGraham01 willGraham01 deleted the meshio-dependency branch February 28, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants