-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement a simple atlas manager widget #153
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #153 +/- ##
==========================================
+ Coverage 97.99% 98.06% +0.06%
==========================================
Files 10 11 +1
Lines 448 464 +16
==========================================
+ Hits 439 455 +16
Misses 9 9 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one tiny suggestion.
I think there's lots of scope to make this easier to use, but I agree that this should just be merged and released, then looked into in the future.
The tests are failing because it took too long to download an atlas. It might be worth giving it a bit more time, GIN can be pretty slow (especially as brainglobe-utils tests are hammering it at the moment).
Description
What is this PR
Why is this PR needed?
We want to separate out atlas download and version management from visualisation.
What does this PR do?
brainrender-napari
now provides two widgets, one for atlas management, one for atlas visualisation.References
Will close #148
This is also a step on the way to #128 and #129
I think this is the best quickfix to get us to a better state than now (with docs and released version out-of-sync), so we can focus on other things as core-devs for a while (after some changes to the docs).
How has this PR been tested?
Integration test added. Manager widget was already there and tested under the hood, just not there in
napari
.Is this a breaking change?
Minor changes in naming.
Does this PR require an update to the documentation?
Yes, to be addressed with brainglobe/brainglobe.github.io#222
Checklist:
brainrender-napari
tutorial is out-of-date brainglobe.github.io#222)